Chrome extension hdokiejnpimakedhajhdlcegeplioahd tabdialog html dialog preferences cmd open

Saved searches

Use saved searches to filter your results more quickly

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

brave / browser-laptop Public archive

Added extension badges #7050

Added extension badges #7050

Conversation

This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).

Test Plan:

1. Enable the LastPass extension
2. From chrome-extension://hdokiejnpimakedhajhdlcegeplioahd/tabDialog.html?dialog=createAccountSimple, open Developer Tools (Ctrl+Shift+I)
3. From console, run chrome.browserAction.setBadgeText()
4. From console, run chrome.browserAction.setBadgeBackgroundColor()

jonathansampson added design A design change, especially one which needs input from the design team. feature/extensions labels Feb 4, 2017

Super pumped you did this great work but I have to bump to 0.13.3 because we’re past frozen date, sorry about that.

@bbondy No worries; with that added time, I’ll do a bit of polishing.

cool thanks, 0.13.3 freeze is Monday end of day, but historically we’re bad about respecting the freeze dates 🙂

@bbondy I’ll have my changes in before then 🙂

@bradleyrichter I put in some logic to center wider badges. Presently, this means anything wider than 20 pixels. Please feel free to polish up any of the styles.

@jonathansampson Ok, I found a tiny size that is still legible at 72dpi.

Your centering plan should work fine.

When we apply this to the brave logo, we should use a dark grey BG color:

@jonathansampson I don’t recall seeing an issue for this (cc: @bradleyrichter) but we have an Asana issue captured for a similar badge on the Lion icon too (so that you know how many items blocked). Would you be able to work on that too?

Badges? We don’t need no stinkin’ badges!

++ as long as this meets @bradleyrichter’s ui specs on all platforms

Didn’t notice any for 1pass even though I had logins for the sites, but may be due to the signing thing for local runs vs builds.

My only critique is that I find the value hard to read, but I do recognize that something is there.

My only negative mark is that the pocket icon seems to have regressed.

Will follow up in a moment with test run results from merging latest master. No merge conflicts detected.

1179 tests passed, 39 pending, 6 failed.
All 6 were timeouts and appeared to be of our intermittent variety.

👍 for merge pending review of pocket icon regression ^^

@alexwykoff I don’t think 1pw has badges. I’ve never seen any on Chrome or Safari

@alexwykoff are you sure the icon for Pocket regressed? When I run master on Windows (without this patch), I’m seeing that icon too. My guess is that the extension has a new icon (maybe Windows only?) It should be the same in Chrome on Windows

@bsclifton I see it on preview 2 but only on x64 but not ia32 build.

It seems to be only in Preview 2. Preview 1 has the same icon on both x64 & ia32. Problem with this icon is there is no visual confirmation if the page is saved or not.

@jonathansampson could you squash this up and add some testing steps? @alexwykoff has already reviewed, I can check it out too and if 👍 we can merge 0.13.6

Rebased and squashed; @NejcZdovc, I added you as a review for when you have time 😄

@jonathansampson would you be able to edit the original post here to provide a test plan? Looks like we’ll want to manually install Honey and then do something which causes updates to happen. More info is appreciated 😄

@bsclifton I can edit, and add a test plan. What relevance is the update action? To test this, we’d want to install an extension, and confirm that the browser action icon is one from the manifest.browser_action.icons property (whether it be a string, or object).

@jonathansampson sorry- I just meant update as in something that causes the numbers to show inside the icon (like in your screenshot at the top, LastPass has the number 27 in it).

I guess that is a good test- just pick LastPass as the default password manager and add some passwords 😄

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use aphrodite and not less

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonathansampson we can help you with the Aphrodite refactor (in fact, @cezaraugusto had put together a really sweet guide which you might find helpful 😄 )

In the meantime, I’ll move this to 0.13.7 😄

@bsclifton @jonathansampson yeah I can help you with it, not a problem

@bsclifton Sorry for the Testing Plan confusion. Half-way through this thread became about a Pocket icon regression. That threw me off.

Test Plan is now added. Essentially, call the two primary APIs from a LastPass extension resource. When enabled, LastPass opens up a chrome-extension: resource for the purposes of creating an account, or logging in. This page will suffice (as far as access/privileges go) to update the LastPass badge with color and text.

Working on Aphrodite changes now.

@NejcZdovc Moved to Aphrodite (as much as I could). There are a couple of places where we don’t know the value of the style property until runtime. Let me know if there’s anything that could be further improved.

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: bordeRadius -> borderRadius

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we get some tests for this? Preferably with a mock extension that is only enabled for testing

- Centers wide badges - Migrate to Aphrodite - Use Hex Colors

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this! 😄 It hasn’t been re-reviewed since @NejcZdovc had given the feedback (which you then implemented). I followed the test steps and verified this works / looks good. ++++!

design A design change, especially one which needs input from the design team. feature/extensions QA/test-plan-specified release-notes/include

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Источник

Chrome extension hdokiejnpimakedhajhdlcegeplioahd tabdialog html dialog preferences cmd open

Auto-suggest helps you quickly narrow down your search results by suggesting possible matches as you type.

• GoTo Community
• ›
• LastPass
• ›
• LastPass Support Discussions
• ›
• LastPass Chrome Extension opens new tab whenever I.

• Subscribe to RSS Feed
• Mark Topic as New
• Mark Topic as Read
• Float this Topic for Current User
• Bookmark
• Subscribe
• Mute
• Printer Friendly Page

• Mark as New
• Bookmark
• Subscribe
• Mute
• Subscribe to RSS Feed
• Permalink
• Print
• Report Inappropriate Content

This is annoying because it does not offer an option to change or disable it in the HotKey preference.

I work on Google Docs in a daily basis, where the same key combination means clear format. The LastPass extension is getting in the way.

RachelO

• Mark as New
• Bookmark
• Subscribe
• Mute
• Subscribe to RSS Feed
• Permalink
• Print
• Report Inappropriate Content

If you quit out of the LastPass mac app, are you then able to use the CMD+\ shortcut once LastPass is closed? If so, this may be a bug. So that our team can gather more details and hopefully resolve this, please submit a bug report following the steps here: https://support.logmeininc.com/lastpass/help/how-do-i-report-a-bug-to-lastpass

RachelO is a member of the LogMeIn Community Care Team.

Was your question answered? Please mark it as an Accepted Solution.
Was a post helpful or informative? Give it a Kudos!

Источник

Saved searches

Use saved searches to filter your results more quickly

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

brave / browser-laptop Public archive

LastPass + New Session Tab #2408

LastPass + New Session Tab #2408

Comments

Two tabs open when using lastpass trying to open a new session tab

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Windows 10
• Brave Version:
  Brave: 0.11.0
  Electron 1.2.3
  libcromiumcontent: 51.0.2704.103
  V8: 5.1.281.65
  Node.js: 6.1.0
  Update Channel: dev
• Steps to reproduce:
  1. I have logged into my Last Pass account
  2. Works flawlessly in current session
  3. Start a New Session tab, it opens the New Session Tab + New Session Tab to login to LastPass again

The text was updated successfully, but these errors were encountered:

That is the expected behavior. The new session tab to login is automatically triggered by LastPass.

actually I guess I’m not sure if you are indicating that the need to login again is a bug or that the opening of the login tab is a bug. The new session tab has it’s own state by definition and LastPass is a web service so you will need to login again. There is a LastPass options page that we need to add a link to, but it doesn’t appear to have any way to turn off the «create account» tab. I’ll contact LastPass and maybe they can add something

Thanks for the replies, yes I was hunting around for a LastPass settings page, but it seems as mentioned not yet implemented.

I guess the issue I should have been more specific but you’ve also mentioned it is the new session ‘create account’ tab is the annoyance part of this. But I also understand that new session means LastPass cannot auto log me in to any sites, but that’s fine.

Basically, I’m a front end developer, and New Session in TAB the way Brave does it is super handy, no more multiple browsers! The forced opening of a second tab asking me to create an account everytime is not so handy.

Источник